Skip to content

Fix base image builds and add PR compatibility validation for 1.29 patch prep#307

Merged
chaptersix merged 12 commits intotemporalio:mainfrom
chaptersix:alex/base-images
Feb 25, 2026
Merged

Fix base image builds and add PR compatibility validation for 1.29 patch prep#307
chaptersix merged 12 commits intotemporalio:mainfrom
chaptersix:alex/base-images

Conversation

@chaptersix
Copy link
Copy Markdown
Contributor

@chaptersix chaptersix commented Feb 24, 2026

What was changed

  • Fixed base-admin-tools cqlsh installation on Alpine by constraining build-time setuptools (setuptools<81) so cassandra-driver source builds continue to work after setuptools v82 removed pkg_resources.
  • Corrected base-server builder image tag from golang:1.25-alpine3.23.3 to valid upstream tag golang:1.25-alpine3.23.
  • Added a dedicated PR workflow (Docker PR Compatibility) that:
    • builds base images from PR changes, and
    • builds downstream server, admin-tools, and auto-setup images against those PR-built base images to validate compatibility.

Why?

We are preparing for a 1.29 patch release and need base image changes to both build reliably and be validated against downstream runtime images during PRs.

Checklist

  1. Closes
    N/A

  2. How was this tested:

  • Reproduced and fixed the cqlsh installation failure in docker/base-images/base-admin-tools.Dockerfile.
  • Verified base-server now references a valid Go Alpine tag.
  • Added PR CI compatibility build path to ensure downstream images build against PR base image changes.
  1. Any docs updates needed?
    No

@chaptersix chaptersix requested a review from a team as a code owner February 24, 2026 21:39
@chaptersix chaptersix marked this pull request as draft February 24, 2026 22:02
@chaptersix chaptersix changed the title update base images Prepare 1.29 patch release Docker image builds Feb 24, 2026
@chaptersix chaptersix changed the title Prepare 1.29 patch release Docker image builds Fix base image builds and add PR compatibility validation for 1.29 patch prep Feb 25, 2026
@chaptersix chaptersix marked this pull request as ready for review February 25, 2026 19:43
@chaptersix
Copy link
Copy Markdown
Contributor Author

feature test s are expect to not build. There was a backward incompatible image build change mad.e

build images fails due to creds that are not available in PR

@chaptersix chaptersix merged commit 8a15447 into temporalio:main Feb 25, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants